Skip to content

cleanup2 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

cleanup2 #271

wants to merge 6 commits into from
+263 −299

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Jul 7, 2025 •
edited
Loading

  • replaced all uses of "PI UID" with "GID"
  • replaced all uses of "org ID" with "GID"
  • removed UnityUser::getUID(), made the uid property public
  • removed UnityGroup::getPIUID(), made the pi_uid / gid property public
  • removed UnityOrg::getOrgID(), made the org_id / gid property public
  • pre-commit threw in styling without my knowledge

@simonLeary42 simonLeary42 marked this pull request as draft July 7, 2025 00:51
@simonLeary42 simonLeary42 marked this pull request as ready for review July 7, 2025 01:08
@simonLeary42 simonLeary42 requested a review from bryank-cs July 7, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryank-cs bryank-cs bryank-cs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonLeary42 @bryank-cs